Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docker): Upgrade Conan to the latest 1.x version #7845

Merged
merged 1 commit into from
Nov 13, 2023
Merged

chore(docker): Upgrade Conan to the latest 1.x version #7845

merged 1 commit into from
Nov 13, 2023

Conversation

fviernau
Copy link
Member

No description provided.

@fviernau fviernau requested a review from a team as a code owner November 10, 2023 10:22
sschuberth
sschuberth previously approved these changes Nov 10, 2023
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Nov 10, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f1c5959) 67.06% compared to head (ab75206) 67.06%.
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #7845   +/-   ##
=========================================
  Coverage     67.06%   67.06%           
  Complexity     2042     2042           
=========================================
  Files           356      356           
  Lines         17045    17045           
  Branches       2438     2438           
=========================================
  Hits          11432    11432           
  Misses         4593     4593           
  Partials       1020     1020
Flag Coverage Δ
funTest-docker 63.19% <ø> (ø)
funTest-non-docker 34.95% <ø> (ø)
test 36.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sschuberth
Copy link
Member

Looks like the major upgrade to Conan 2 needs some more changes: 'info' is not a Conan command. See 'conan --help'.

@fviernau fviernau added the on hold Pull requests that cannot currently be merged label Nov 10, 2023
@fviernau
Copy link
Member Author

Looks like the major upgrade to Conan 2 needs some more changes: 'info' is not a Conan command. See 'conan --help'.

Seems like in addition also the conanfile format has changed. Do we need to keep 1.x support then and have 2.x support in parallel?

@sschuberth
Copy link
Member

Do we need to keep 1.x support then and have 2.x support in parallel?

I believe we need 1.x support, yes, but the people from Bosch might be better to tell. My question is rather: Do we need 2.x support (yet)?

@mnonnenmacher
Copy link
Member

Do we need to keep 1.x support then and have 2.x support in parallel?

I believe we need 1.x support, yes, but the people from Bosch might be better to tell. My question is rather: Do we need 2.x support (yet)?

Yes, we need 1.x support and will likely need to support both versions in parallel in future.

@fviernau fviernau force-pushed the docker-upgrade-conan branch from 3a7414c to dc0589f Compare November 13, 2023 07:31
@fviernau
chore(docker): Upgrade Conan to the latest 1.x version
ab75206 
Not upgrading to version 2, because it is not backwards compatible with
version one.

Signed-off-by: Frank Viernau <[email protected]>
@fviernau fviernau force-pushed the docker-upgrade-conan branch from dc0589f to ab75206 Compare November 13, 2023 07:31
@fviernau
Copy link
Member Author

Yes, we need 1.x support and will likely need to support both versions in parallel in future.

So, then let's just try latest 1.x version in this PR.

@fviernau fviernau changed the title chore(docker): Upgrade Conan to the latest version chore(docker): Upgrade Conan to the latest 1.x version Nov 13, 2023
@fviernau fviernau removed the on hold Pull requests that cannot currently be merged label Nov 13, 2023
@fviernau fviernau merged commit 5dd26aa into main Nov 13, 2023
36 checks passed
@fviernau fviernau deleted the docker-upgrade-conan branch November 13, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sschuberth sschuberth sschuberth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fviernau @sschuberth @mnonnenmacher