advisor: Add the missing handling to query the Hackage ecostem to Osv #7844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
force-pushed
the
osv-support-hackage
branch
from
13dda4d to
6228ab4
Compare
fviernau
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7844 +/- ##
=========================================
Coverage 67.05% 67.05%
Complexity 2042 2042
=========================================
Files 356 356
Lines 17043 17043
Branches 2438 2438
=========================================
Hits 11429 11429
Misses 4594 4594
Partials 1020 1020
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
approved these changes
Nov 10, 2023
Update the packages IDs such that for each a non-empty set of vulnerabilities is returned. Signed-off-by: Frank Viernau <[email protected]>
The previous assertion would have passed for a packages for which either the ecosystem is not supported or for which no vulnerability is returned. Signed-off-by: Frank Viernau <[email protected]>
Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
osv-support-hackage
branch
from
6228ab4 to
400b6f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.