Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): Update links #7696

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

nnobelis
Copy link
Member

No description provided.

@nnobelis nnobelis requested a review from a team as a code owner October 13, 2023 11:40
@@ -287,7 +287,7 @@ justify the resolution on a global scale.
|-------------|--------|-----------------------------------|
| YAML / JSON | Global | `$ORT_CONFIG_DIR/resolutions.yml` |

#### [Repository configuration file](./docs/config-file-ort-yml.md)
#### [Repository configuration file](./website/docs/configuration/ort-yml.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all title links in this section starting with "Copyright garbage file" are broken. Mind fixing them as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed some #7700.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually @nnobelis had already fixed the other links in this PR. Let's take this PR from him and rebase yours on top.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4591c6a) 68.05% compared to head (0061f6b) 68.05%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7696   +/-   ##
=========================================
  Coverage     68.05%   68.05%           
  Complexity     2025     2025           
=========================================
  Files           345      345           
  Lines         16735    16735           
  Branches       2366     2366           
=========================================
  Hits          11389    11389           
  Misses         4367     4367           
  Partials        979      979           
Flag Coverage Δ
funTest-non-docker 36.31% <ø> (ø)
test 34.80% <ø> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Nicolas Nobelis <[email protected]>
@nnobelis
Copy link
Member Author

nnobelis commented Oct 13, 2023

@sschuberth The tests failures are related to links I didn't change. How do you understand that ?

@sschuberth
Copy link
Member

@sschuberth The tests failures are related to links I didn't change. How do you understand that ?

I believe the markdown-links failures are valid, though probably not related to your changes. Mind still fixing these, too?

The funTest-docker failure is unrelated, but should disappear now on a rebase.

@sschuberth sschuberth merged commit 39c0534 into oss-review-toolkit:main Oct 15, 2023
@nnobelis nnobelis deleted the nnobelis/fix_doc branch November 20, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants