-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(README): Update links #7696
docs(README): Update links #7696
Conversation
@@ -287,7 +287,7 @@ justify the resolution on a global scale. | |||
|-------------|--------|-----------------------------------| | |||
| YAML / JSON | Global | `$ORT_CONFIG_DIR/resolutions.yml` | | |||
|
|||
#### [Repository configuration file](./docs/config-file-ort-yml.md) | |||
#### [Repository configuration file](./website/docs/configuration/ort-yml.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like all title links in this section starting with "Copyright garbage file" are broken. Mind fixing them as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed some #7700.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually @nnobelis had already fixed the other links in this PR. Let's take this PR from him and rebase yours on top.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7696 +/- ##
=========================================
Coverage 68.05% 68.05%
Complexity 2025 2025
=========================================
Files 345 345
Lines 16735 16735
Branches 2366 2366
=========================================
Hits 11389 11389
Misses 4367 4367
Partials 979 979
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Nicolas Nobelis <[email protected]>
64da439
to
0061f6b
Compare
@sschuberth The tests failures are related to links I didn't change. How do you understand that ? |
I believe the markdown-links failures are valid, though probably not related to your changes. Mind still fixing these, too? The funTest-docker failure is unrelated, but should disappear now on a rebase. |
No description provided.