Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conan): Do not hard-code the VCS type to "Git" #6839

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

sschuberth
Copy link
Member

Fixes #6827.

@sschuberth sschuberth requested a review from a team as a code owner April 12, 2023 20:27
@sschuberth sschuberth enabled auto-merge (rebase) April 12, 2023 20:28
@sschuberth sschuberth force-pushed the conan-no-hard-code-git branch from 471e1b6 to 6e96dc0 Compare April 12, 2023 20:34
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.08 🎉

Comparison is base (b044327) 64.59% compared to head (3966d94) 64.67%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6839      +/-   ##
============================================
+ Coverage     64.59%   64.67%   +0.08%     
  Complexity     1945     1945              
============================================
  Files           322      323       +1     
  Lines         16170    16152      -18     
  Branches       2299     2303       +4     
============================================
+ Hits          10445    10447       +2     
+ Misses         4728     4708      -20     
  Partials        997      997              
Flag Coverage Δ
funTest-docker 64.44% <ø> (-0.10%) ⬇️
funTest-non-docker 49.33% <ø> (ø)
test 32.48% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

fviernau
fviernau previously approved these changes Apr 12, 2023
@sschuberth sschuberth merged commit 7df497b into main Apr 13, 2023
@sschuberth sschuberth deleted the conan-no-hard-code-git branch April 13, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.IllegalArgumentException in analyzer if project doesn't have a repository
2 participants