refactor(black-duck): Move two variables out of a block

Avoid recomuting the values and reduce the nesting level. Signed-off-by: Frank Viernau <[email protected]>
oss-review-toolkit · Jan 29, 2025 · d44e232 · d44e232
1 parent 668b36a
commit d44e232
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/plugins/advisors/black-duck/src/main/kotlin/BlackDuck.kt b/plugins/advisors/black-duck/src/main/kotlin/BlackDuck.kt
@@ -199,12 +199,11 @@ class BlackDuck(
 
 internal fun VulnerabilityView.toOrtVulnerability(): Vulnerability {
     val referenceUris = setOf(meta.href.uri(), *meta.links.map { it.href.uri() }.toTypedArray())
+    val cvssVector = cvss3?.vector ?: cvss2?.vector
+    // Only CVSS version 2 vectors do not contain the "CVSS:" label and version prefix
+    val scoringSystem = cvssVector?.substringBefore('/', Cvss2Rating.PREFIXES.first())
 
     val references = referenceUris.map { uri ->
-        val cvssVector = cvss3?.vector ?: cvss2?.vector
-        // Only CVSS version 2 vectors do not contain the "CVSS:" label and version prefix
-        val scoringSystem = cvssVector?.substringBefore('/', Cvss2Rating.PREFIXES.first())
-
         VulnerabilityReference(
             url = uri,
             scoringSystem = scoringSystem,