feat(model): Match the type case insensitively in package configurations

Make the matching of the identifier type in package configurations case insensitive to align with package curations. Signed-off-by: Martin Nonnenmacher <[email protected]>
oss-review-toolkit · Feb 13, 2025 · 5956a45 · 5956a45
1 parent cd855be
commit 5956a45
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/model/src/main/kotlin/config/PackageConfiguration.kt b/model/src/main/kotlin/config/PackageConfiguration.kt
@@ -71,7 +71,14 @@ data class PackageConfiguration(
     }
 
     fun matches(otherId: Identifier, provenance: Provenance): Boolean {
-        if (id != otherId) return false
+        @Suppress("ComplexCondition")
+        if (!id.type.equals(otherId.type, ignoreCase = true) ||
+            id.namespace != otherId.namespace ||
+            id.name != otherId.name ||
+            id.version != otherId.version
+        ) {
+            return false
+        }
 
         return when (provenance) {
             is UnknownProvenance -> false

diff --git a/model/src/test/kotlin/config/PackageConfigurationTest.kt b/model/src/test/kotlin/config/PackageConfigurationTest.kt
@@ -136,5 +136,24 @@ class PackageConfigurationTest : WordSpec({
                 )
             ) shouldBe false
         }
+
+        "return true if the identifier type is equal ignoring case" {
+            val config =
+                vcsPackageConfig(name = "some-name", revision = "12345678", url = "ssh://git@host/repo.git").let {
+                    it.copy(id = it.id.copy(type = "Gradle"))
+                }
+
+            config.matches(
+                config.id.copy(type = "gradle"),
+                RepositoryProvenance(
+                    vcsInfo = VcsInfo(
+                        type = VcsType.GIT,
+                        url = "ssh://git@host/repo.git",
+                        revision = ""
+                    ),
+                    resolvedRevision = "12345678"
+                )
+            ) shouldBe true
+        }
     }
 })