chore(ort-utils): Warn if a mapping to an invalid license is configured

Signed-off-by: Sebastian Schuberth <[email protected]>
oss-review-toolkit · Jun 6, 2024 · 19cfe2a · 19cfe2a
1 parent 0efd110
commit 19cfe2a
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/utils/ort/src/main/kotlin/DeclaredLicenseProcessor.kt b/utils/ort/src/main/kotlin/DeclaredLicenseProcessor.kt
@@ -92,9 +92,17 @@ object DeclaredLicenseProcessor {
             ?: SpdxDeclaredLicenseMapping.map(strippedLicense)
             ?: SpdxDeclaredLicenseMapping.map(strippedLicense.unquote())
             ?: SpdxDeclaredLicenseMapping.map(strippedLicense.removePrefix(SpdxConstants.TAG).trim())
-            ?: parseLicense(strippedLicense)
 
-        return mappedLicense?.normalize()?.takeIf { it.isValid() || it.toString() == SpdxConstants.NONE }
+        if (mappedLicense?.isValid() == false) {
+            logger.warn {
+                "Declared license '$declaredLicense' is configured to map to '$mappedLicense' which is not a valid " +
+                    "SPDX expression."
+            }
+        }
+
+        val processedLicense = mappedLicense ?: parseLicense(strippedLicense)
+
+        return processedLicense?.normalize()?.takeIf { it.isValid() || it.toString() == SpdxConstants.NONE }
     }
 
     /**