Skip to content

feat(Repository): Use KnownProvenance instead of VcsInfo #15679

feat(Repository): Use KnownProvenance instead of VcsInfo

feat(Repository): Use KnownProvenance instead of VcsInfo #15679

Triggered via pull request June 19, 2024 15:04
Status Failure
Total duration 8m 34s
Artifacts

static-analysis.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

2 errors, 10 warnings, and 1 notice
commit-lint
You have commit messages with errors ⧗ input: Draft: feat(Repository): Use `KnownProvenance` instead of `VcsInfo` This commit is still a draft. In order to allow source artifacts as well as local source code to be scanned, we require a more generallized Repository, which allows any type of `KnownProvenance`. While we still set the signature of `Repository` to allow `KnownProvenance`s, this commit focuses on accomidateing `RepositoryProvenance` as then main input for now. Therefore we wrap `VcsInfo` with `RepositoryProvenance`, whenever it is used as input, and unwrap it, when it is produced as output. This gives us a quick update of the now depreacted code, without the necessity to support all `KnownProvenance` types from the get go. This commit compiles without errors, but still fails tests, due to the now changed `OrtResult` structure and output. Fixed tests must be squshed into this commit before merging. Signed-off-by: Jens Keim <[email protected]> ✖ type must be lower-case [type-case] ✖ type must be one of [build, chore, ci, deps, docs, feat, fix, perf, refactor, revert, style, test] [type-enum] ⚠ subject must be pascal-case, sentence-case, start-case, upper-case [subject-case] ✖ found 2 problems, 1 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: Draft: test(OrtResult): Change `Repository` structure in expected files This commit is the first attempt to fix the `OrtResult` related tests. Signed-off-by: Jens Keim <[email protected]> ✖ type must be lower-case [type-case] ✖ type must be one of [build, chore, ci, deps, docs, feat, fix, perf, refactor, revert, style, test] [type-enum] ⚠ subject must be pascal-case, sentence-case, start-case, upper-case [subject-case] ✖ found 2 problems, 1 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: Change CamelCase to snail_case ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint ⧗ input: Readd `vcs` and `vcs_processed` temporarily ✖ subject may not be empty [subject-empty] ✖ type may not be empty [type-empty] ✖ found 2 problems, 0 warnings ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
detekt-issues
Process completed with exit code 1.
Unresolved reference in KDoc: reporter/src/main/kotlin/StatisticsCalculator.kt#L37
Cannot resolve symbol 'RuleViolationResolution'
Unresolved reference in KDoc: reporter/src/main/kotlin/StatisticsCalculator.kt#L36
Cannot resolve symbol 'IssueResolution'
Unresolved reference in KDoc: model/src/main/kotlin/licenses/LicenseInfo.kt#L141
Cannot resolve symbol 'nestedRepositories'
Unresolved reference in KDoc: helper-cli/src/main/kotlin/utils/Extensions.kt#L203
Cannot resolve symbol 'RuleViolation'
Unresolved reference in KDoc: model/src/main/kotlin/Repository.kt#L43
Cannot resolve symbol 'ORT_REPO_CONFIG_FILENAME'
Unresolved reference in KDoc: model/src/main/kotlin/licenses/LicenseInfo.kt#L144
Cannot resolve symbol 'RepositoryConfiguration'
Class member can have 'private' visibility: model/src/main/kotlin/Repository.kt#L48
Property 'DEFAULT_REVISION' could be private