feat(curations): Add a VCS curation for NPM::lit #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cz-dev-ge
commented
Sep 23, 2025
cz-dev-ge
commented
- Adds correct release commit
- Adds path to actual package code
Signed-off-by: cz-dev-ge <[email protected]>
cz-dev-ge
changed the title
sschuberth
reviewed
Sep 23, 2025
| vcs: | ||
| type: "Git" | ||
| url: "https://github.com/lit/lit.git" | ||
| revision: "3677f3faac8c3d6ea6e04f0f06c70c9637f501b8" |
There was a problem hiding this comment.
Hmm, https://registry.npmjs.org/lit#/versions/2.2.2/gitHead actually points to 6022c984b35e6aa4b6403048ffee3c8d01a8ad2c.
There was a problem hiding this comment.
Ok. Strange. I found that, too. That's the tag [email protected]. But in lit/lit@3677f3f the version in packages/lit/package.json is actually changed to 2.2.2. That tripped me up. But I guess we need to use the information from the package metadata.
There was a problem hiding this comment.
But I guess we need to use the information from the package metadata.
Let's say it like this: It's difficult to justify otherwise 😉
sschuberth
reviewed
Sep 23, 2025
| type: "Git" | ||
| url: "https://github.com/lit/lit.git" | ||
| revision: "3677f3faac8c3d6ea6e04f0f06c70c9637f501b8" | ||
| path: "packages/lit" |
There was a problem hiding this comment.
But this is actually valuable to keep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.