ova: set os type and virtual hardware version (HMS-3248)#2480
Draft
croissanne wants to merge 1 commit into
Draft
ova: set os type and virtual hardware version (HMS-3248)#2480croissanne wants to merge 1 commit into
croissanne wants to merge 1 commit into
Conversation
croissanne
force-pushed
the
ovf-stuff
branch
3 times, most recently
from
2eed9d8 to
a1429bc
Compare
Setting the appropriate os type and virtual hardware version can dramatically impact performance on platforms like vSphere.
supakeen
reviewed
Jul 2, 2026
Comment on lines
+558
to
+560
| DiskImageVMWareOVFOSType string `yaml:"disk_image_vmware_ovf_os_type"` | ||
| DiskImageVMWareOVFVirtualHardwareVersion string `yaml:"disk_image_vmware_ovf_virtual_hardware_version"` | ||
|
|
Member
There was a problem hiding this comment.
Let's put them under DiskConfig (line 519)? Perhaps even under a VMWare struct inside it.
I've been trying to find some logical grouping to all the configs we have but this one seems like it has a good place to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting the appropriate os type and virtual hardware version can dramatically impact performance on platforms like vSphere.