many: drop custom distrodefs and use images DistroYAML
#1066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update go.mod and do the required AI changes for v0.197.0
The error message on mismatch of `--target-arch` with the actual container has changed (for the better) so we need to update the test for this.
With the merge of osbuild/images#1886 the handling of the lorax templates changed. Ideally we would follow images here closer and use the distro YAML loader to load the metadata from images:data/distrodefs. But as a quick fix this just duplicates the logic we had before.
Instead of having a separate implementation of the required packages and the required lorax templates and similar we now reuse the images `data/distrodefs` YAML so that all the packages/definitions are maintained in a central place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[build on top of #1065 - only the last commit is relevant for this]
Draft as this requires some work in "images" too:
Instead of having a separate implementation of the required
packages and the required lorax templates and similar we
now reuse the images
data/distrodefsYAML so that allthe packages/definitions are maintained in a central place.