Make desktop notifications feature (dbus) optional #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Statically-linked tiny works great on Windows under WSL!
|
|
I think I found a way to make dbus opt-out without making installation story worse: just make a |
|
Ugh.. I keep forgetting this. The idea above is not possible as cargo features are supposed to be "additive". I guess we'll have to write detailed installation instructions in README. |
This makes dbus dependency opt-in by making desktop notifications an
optional feature.
We also make native-tls optional and rustls the default. The idea is
that `cargo build` will be easier to build because it doesn't need any
system dependencies, and features that need system dependencies will be
hidden behind feature flags.
After this patch: (all commands in 'tiny' directory)
- dbus + rustls:
cargo build --features="desktop-notifications"
- dbus + native-tls
cargo build --features="desktop-notifications tls-native" \
--no-default-features
Removing "desktop-notifications" will make a build without dbus
dependency.
It's now possible to make a statically-linked executable with
$ cargo build --target=x86_64-unknown-linux-musl
(#65)
|
I'm still not sure if this is a good idea, but I made rustls the default and desktop notifications opt-in. See commit msg for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this I can make a statically linked executable with
The generated executable does not support generating desktop
notifications and uses rustls instead of libssl.
(#65)