Repository navigation
chore: disable SQLite disk sync in benchmarks to reduce walltime noise - #1841
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Merging this PR will improve performance by ×2.5
Performance Changes
Tip Curious why performance improved? Comment Comparing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmarks that write rows one by one were dominated by SQLite fsync and journal-file I/O, so CodSpeed's walltime runs flagged random 15–30% "regressions" on PRs that never touch those code paths (e.g. #1840, #1824). The benchmark fixture now sets
PRAGMA synchronous=OFFandjournal_mode=MEMORYon SQLite connections, so these benchmarks measure ormar overhead instead of disk latency.Locally, over 3 runs of the 21 write-per-row benchmarks, the mean run-to-run spread dropped from 17% to 6% (max 39% → 12%). Expect the first CodSpeed report here to show large improvements on those benchmarks, as the baseline resets once this is merged.