Repository navigation
fix: copy order actions in prefetch so querysets can be re-executed - #1825
Open
moneebullah25 wants to merge 2 commits into
Open
moneebullah25 wants to merge 2 commits into
moneebullah25 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1818
LoadNodemutated the sharedOrderActionobjects (is_source_model_order,table_prefix) while building prefetch queries, so executing the same queryset a second time withprefetch_related+order_byon a related field gave wrong results. The order action is now copied before it is modified.Changes:
ormar/queryset/queries/prefetch_query.py:copy.copythe order action before mutating it.tests/test_relations/test_prefetch_related.py: regression test that runs the same queryset twice.Checks run:
ruff format --checkandruff checkon the changed files: cleanmypy --ignore-missing-importson the changed files: no issuespytest tests/test_relations/test_prefetch_related.py tests/test_queries: 112 passedTests added for the change
Linting and type checks run on changed files
Docs updated (not applicable)