Null-safe share-scope merge #722
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug occurring when loading a VitePluginFederation remote in an application that mixes ModuleFederation and VitePluginFederation remotes.
When a remote ModuleFederation is already present in the share scope, a
loading: nullproperty is set (source).During share scope merging, since
typeof null === "object", the call toObject.assign(null, …)throws the following error:Cannot convert undefined or null to object.This fix adds a null check to prevent calling
Object.assignon anullvalue.(maybe it is recommended to have a dedicated scope for this kind of case?)
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).