Fixed Pslam errors

orchidsoftware · Feb 3, 2025 · b59abea · b59abea
1 parent 581c908
commit b59abea
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/Attachment/Engines/Generator.php b/src/Attachment/Engines/Generator.php
@@ -8,6 +8,7 @@
 use Illuminate\Support\Str;
 use Orchid\Attachment\Contracts\Engine;
 use Orchid\Attachment\MimeTypes;
+use RuntimeException;
 
 class Generator implements Engine
 {
@@ -107,7 +108,16 @@ public function setPath(?string $path = null): static
      */
     public function hash(): string
     {
-        return sha1_file($this->file->path());
+        $hash = sha1_file($this->file->path());
+
+        if ($hash === false) {
+            throw new RuntimeException(sprintf(
+                'Failed to generate a hash for the file: %s.',
+                $this->file->path()
+            ));
+        }
+
+        return $hash;
     }
 
     /**

diff --git a/src/Attachment/Models/Attachment.php b/src/Attachment/Models/Attachment.php
@@ -126,7 +126,7 @@ public function getRelativeUrlAttribute(): ?string
             return null;
         }
 
-        return parse_url($url, PHP_URL_PATH);
+        return parse_url($url, PHP_URL_PATH) ?: null;
     }
 
     public function getTitleAttribute(): ?string