feat: Show annotations in default discovery output #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Horiodino <[email protected]>
Horiodino
requested review from
sajayantony,
shizhMSFT,
SteveLasker,
qweeah and
TerryHowe
as code owners
TerryHowe
reviewed
Jan 6, 2025
cmd/oras/internal/option/format.go
Outdated
| @@ -68,6 +68,11 @@ var ( | |||
| Name: "text", | |||
| Usage: "Print in text format", | |||
| } | |||
|
|
|||
| FormatTypeTreeFull = &FormatType{ | |||
| Name: "tree-full", | |||
There was a problem hiding this comment.
I'm not in love with the name tree-full, but I don't have a better idea.
There was a problem hiding this comment.
I do like the idea of showing the annotations in the normal tree view.
There was a problem hiding this comment.
Sorry for changes in direction on this @Horiodino
There was a problem hiding this comment.
Let's continue the discussion in #1534. We will temporarily hold on this PR until we aligned the user experience. Apologies for blocking you @Horiodino
Signed-off-by: Horiodino <[email protected]>
shizhMSFT
changed the title
shizhMSFT
changed the title
--format tree-full flag
Signed-off-by: Horiodino <[email protected]>
|
The title of this PR needs to be updated when you get a chance |
Horiodino
changed the title
--format tree-full flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces a new
--format tree-fullflag for theoras discovercommand, as outlined in the ORAS diagnose experience proposal. The flag enables users to control the level of metadata output when discovering artifacts, including detailed annotations. By adding this feature, users will be able to print more granular metadata about the artifacts, which will improve the overall diagnostic and troubleshooting experience.Which issue(s) this PR fixes *
Fixes #1534
Please check the following list: