On branch edburns/o-669-add-improved-setup-credentials #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your branch is up to date with 'origin/edburns/o-669-add-improved-setup-credentials'. Untracked files: (use "git add <file>..." to include in what will be committed) .github/resource/azure-credential-setup.sh .github/resource/credentials-params.yaml .github/workflows/setup-credentials.sh nothing added to commit but untracked files present (use "git add" to track) Signed-off-by: Ed Burns <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
backwind1233
suggested changes
Aug 20, 2025
Comment on lines
41
to
49
| - name: ELK_URI | ||
| value: "" | ||
| description: Elastic server URI (optional VM) | ||
| - name: ELK_USER_NAME | ||
| value: "" | ||
| description: Elastic user name (optional VM) | ||
| - name: ELK_PSW | ||
| value: "" | ||
| description: Elastic password (optional VM) |
There was a problem hiding this comment.
I would recommend commenting these parameters, otherwise users must provide values here.
the credentials-params-setup.sh will stop if there are some empty values.
Your branch is up to date with 'origin/edburns/o-669-add-improved-setup-credentials'. Untracked files: (use "git add <file>..." to include in what will be committed) .github/resource/azure-credential-teardown.sh nothing added to commit but untracked files present (use "git add" to track) Signed-off-by: Ed Burns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your branch is up to date with 'origin/edburns/o-669-add-improved-setup-credentials'.
Untracked files:
(use "git add ..." to include in what will be committed)
.github/resource/azure-credential-setup.sh
.github/resource/credentials-params.yaml
.github/workflows/setup-credentials.sh
nothing added to commit but untracked files present (use "git add" to track)