Skip to content

chore: add minor code improvements to the typosquatting heuristic #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AmineRaouane
Copy link
Member

Summary

some improvement for the typosquatting heuristic

Description of changes

  • bash file to fetch the top downloaded packages in last month and store them in popular_packages.txt

Related issues

Checklist

  • I have reviewed the contribution guide.
  • My PR title and commits follow the Conventional Commits convention.
  • My commits include the "Signed-off-by" line.
  • I have signed my commits following the instructions provided by GitHub. Note that we run GitHub's commit verification tool to check the commit signatures. A green verified label should appear next to all of your commits on GitHub.
  • I have updated the relevant documentation, if applicable.
  • I have tested my changes and verified they work as expected.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 12, 2025
@behnazh-w behnazh-w changed the title chore: minor code improvements chore: add minor code improvements to the typosquatting heuristic Jul 18, 2025
@AmineRaouane AmineRaouane force-pushed the typosquatting-improvement branch from aa96219 to f74818c Compare July 18, 2025 09:31
Copy link
Member

@art1f1c3R art1f1c3R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, ran it through shellcheck and all looks fine, ran it locally and worked with no errors.

@behnazh-w
Copy link
Member

@AmineRaouane Could you please add a note in the README.md explaining why Macaron maintainers should run this script, where it should be executed from (the path), and include an example command for clarity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants