Fix for OCI Generative AI tool_call_id not found because AIMessage.tool_calls are ignored #43
+163
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
YouNeedCryDear
approved these changes
Oct 14, 2025
|
@jbrown9513 Thank you for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for fixing the following issue - #42
To verify the fix works correctly, you can test it by:
Comment out the fix in libs/oci/langchain_oci/chat_models/oci_generative_ai.py line 716:
Run the new unit tests:
cd libs/oci poetry run pytest tests/unit_tests/chat_models/test_oci_generative_ai.py::test_ai_message_tool_calls_direct_field -v poetry run pytest tests/unit_tests/chat_models/test_oci_generative_ai.py::test_ai_message_tool_calls_additional_kwargs -vConfirm failure
=================================== FAILURES =================================== ___________________ test_ai_message_tool_calls_direct_field ____________________Restore the fix by uncommenting the line:
Run the tests again to confirm they pass with the fix in place.