-
Notifications
You must be signed in to change notification settings - Fork 47
[DRCC][AQUA] Completely Removing OSS bucket config dependency #1147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kumar-shivam-ranjan
merged 11 commits into
main
from
feature/oss-bucket-config-dependency
Apr 9, 2025
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f62eb5d
Removing oss bucket config
kumar-shivam-ranjan 7795394
Enhancing list model api + config dependency removal
kumar-shivam-ranjan 20933af
Removing print statements
kumar-shivam-ranjan eb88b11
Removing ODSC_MODEL_COMPARTMENT_OCID
kumar-shivam-ranjan 9c5d54f
Merge branch 'aqua/ADS_MS_changes' into feature/oss-bucket-config-dep…
kumar-shivam-ranjan f10ac55
Merge branch 'main' into feature/oss-bucket-config-dependency
kumar-shivam-ranjan d7affcc
Merge branch 'feature/oss-bucket-config-dependency' of https://github…
kumar-shivam-ranjan 3ed30fa
Fixing env variable override issue
kumar-shivam-ranjan a80395a
Removing from_container_index method
kumar-shivam-ranjan e5ee1bb
Addressing review comments
kumar-shivam-ranjan 644d53c
Updating logging messages
kumar-shivam-ranjan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this always returns ok, does UI need to call this? This won't be needed, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is compatibility check handler implemented in websockets. We call the one implemented via HTTP. Both the methods should return ok always as we decide to enable AQUA everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes , we can remove calling this API in UI. I kept it since may be in future we can add some sort of AQUA enabling logic based on CP config. Are you suggesting we removing this api alltogether from ADS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Thanks