PR: Initial Software Versioning and Data Persistence for Services

[dkennetzoracle]

Summary:

• Add specific versions to helm chart installations
• Add persistent volumes to services so data persists across restarts
• Add initial software versioning documentation and templating
• Some dead code cleanup

[amgowda-oci]

left inline comments

[amgowda-oci]

Can you add a sample releasenotes.md file?

[dkennetzoracle]

Added a template at top level called RELEASE_NOTES.md

[amgowda-oci]

make sure you use the "oci-bv" class and min volume size of 50 GB

apiVersion: v1 kind: PersistentVolumeClaim metadata: name: mynginxclaim spec: storageClassName: "oci-bv" accessModes: - ReadWriteOnce resources: requests: storage: 50Gi

[dkennetzoracle]

They are specified in the pvc (in terraform resource below), you just specify the claimName when bringing your own volume:

resource "kubernetes_persistent_volume_claim_v1" "mlflow" {
  metadata {
    name      = "mlflow-pvc"
    namespace = "cluster-tools"
  }

  spec {
    access_modes = ["ReadWriteOnce"]

    resources {
      requests = {
        storage = "50Gi"
      }
    }

    storage_class_name = "oci-bv"
  }
  ...

[amgowda-oci]

We should upgrade grafana versions to latest, this is how I deploy, I am sure there is an existing TF how to do this tag. Or may be you are deploying the latest.

apiVersion: v1
kind: PersistentVolumeClaim
metadata:
 name: grafana-pvc
spec:
 storageClassName: "oci-bv"
 accessModes:
   - ReadWriteOnce
 resources:
   requests:
     storage: 5Gi
---
apiVersion: apps/v1
kind: Deployment
metadata:
 labels:
   app: grafana
 name: grafana
spec:
 selector:
   matchLabels:
     app: grafana
 template:
   metadata:
     labels:
       app: grafana
   spec:
     securityContext:
       fsGroup: 472
       supplementalGroups:
         - 0
     containers:
       - name: grafana
         image: grafana/grafana:latest
         imagePullPolicy: IfNotPresent
         ports:
           - containerPort: 3000
             name: http-grafana
             protocol: TCP
         readinessProbe:
           failureThreshold: 3
           httpGet:
             path: /robots.txt
             port: 3000
             scheme: HTTP
           initialDelaySeconds: 10
           periodSeconds: 30
           successThreshold: 1
           timeoutSeconds: 2
         livenessProbe:
           failureThreshold: 3
           initialDelaySeconds: 30
           periodSeconds: 10
           successThreshold: 1
           tcpSocket:
             port: 3000
           timeoutSeconds: 1
         resources:
           requests:
             cpu: 2
             memory: 3500Mi
         volumeMounts:
           - mountPath: /var/lib/grafana
             name: grafana-pv
     volumes:
       - name: grafana-pv
         persistentVolumeClaim:
           claimName: grafana-pvc
---
apiVersion: v1
kind: Service
metadata:
 name: grafana
spec:
 ports:
   - port: 3000
     protocol: TCP
     targetPort: http-grafana
 selector:
   app: grafana
 sessionAffinity: None
 type: LoadBalancer

[dkennetzoracle]

I'll bump and test with the most recent version 👍

[dkennetzoracle]

Currently, we are back quite a few!

    grafana                = "https://grafana.github.io/helm-charts"
    grafana_version        = "6.47.1"

[dkennetzoracle]

@amgowda-oci maybe let's hold off on this in this PR. Both Grafana and Prometheus broke when I updated to latest (granted they had major version updates which indicates breaking changes). They both would need some work.

[amgowda-oci]

looks good