Repository navigation
Make JournalStorage.may_omit_trials() reflect apply_discard - #306
Merged
Merged
Conversation
c-bata
marked this pull request as ready for review
November 13, 2026 01:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
may_omit_trials()is documented as "Return True if this storage view may omit discarded trials."InMemoryStorageandSQLite3Storagereturn theirapply_discardoption, butJournalStoragereturned whether a discarded trial had already been replayed. As a result, aJournalFileStoragecreated withapply_discard=TruereportedFalseuntil the first discard was applied.Changes
apply_discardfromJournalStorage::may_omit_trials(), consistent withInMemoryStorageandSQLite3Storage.may_omit_trials()followsapply_discardboth before and after a discard.JournalFileStorage(..., apply_discard=True).may_omit_trials()isTruebefore any trial is discarded.