Repository navigation
Fix user attributes of enqueued trials returned by ask - #299
Merged
Merged
Conversation
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Trial.user_attrsof a trial returned byStudy.ask()does not include the user attrs given toStudy.enqueue_trial(). They are stored in the storage, but the trial object does not show them. This is different from Optuna, whereTrial.user_attrsreturns them.This happens because
Trialkeeps user attrs in a cache (cached_user_attrs). The cache always starts empty and is only updated byTrial.set_user_attr(s).Description of the changes
Study.ask()takes a trial from the trial queue, fill the user attr cache of the trial with the user attrs in the storage. This is the same place where the fixed params are read.Trial. Only the initial value of the cache changes.test_ask_returns_user_attrs_of_enqueued_trial), and checktrial.user_attrsin the existing Python testtest_enqueue_trial_with_user_attrs, which runs for every trial queue type.