FIX: Forced variation not available in experiment (#237)

* Php forced Decision fix

* added unit test and comments

* nit fix

* Added empty checks in flagkey and experiment key

* removed unnesecary checks and moved getVariationFromExperiment above and then checking             $variation = $config->getFlagVariationByKey($flagKey, $variationKey);

* lint fix

Co-authored-by: mnoman09 <[email protected]>

Author: mnoman09

src/Optimizely/Event/Builder/EventBuilder.php

@@ -252,12 +252,13 @@ public function createImpressionEvent($config, $experimentId, $variationKey, $fl
         $eventParams = $this->getCommonParams($config, $userId, $attributes);
         $experiment = $config->getExperimentFromId($experimentId);
 
-        if (empty($experimentId)) {
+        // When variation is not mapped to any flagKey
+        $variation = $config->getVariationFromKeyByExperimentId($experimentId, $variationKey);
+
+        // Mapped flagKey can be directly used in variation in that case no experimentKey exist
+        if ($variation && !$variation->getKey()) {
             $variation = $config->getFlagVariationByKey($flagKey, $variationKey);
-        } else {
-            $variation = $config->getVariationFromKeyByExperimentId($experimentId, $variationKey);
         }
-
         $impressionParams = $this->getImpressionParams($experiment, $variation, $flagKey, $ruleKey, $ruleType, $enabled);
 
         $eventParams[VISITORS][0][SNAPSHOTS][] = $impressionParams;

tests/EventTests/EventBuilderTest.php

@@ -157,6 +157,53 @@ public function testCreateImpressionEventNoAttributesNoValue()
         $this->assertTrue($result[0], $result[1]);
     }
 
+    public function testCreateImpressionEventVariationFromSameFlagButDifferentExperiments()
+    {
+        $decisions = array('decisions' => [[
+            'campaign_id'=> '5',
+            'experiment_id'=> '122235',
+            'variation_id'=> '177775',
+            'metadata'=> [
+                'flag_key' => 'string_single_variable_feature',
+                'rule_key' => 'test_experiment_with_feature_rollout',
+                'rule_type' => 'experiment',
+                'variation_key'=> '177775',
+                'enabled' => true
+            ]
+          ]]
+        );
+        $this->expectedImpressionEventParams['visitors'][0]['snapshots'][0] = $decisions +
+                                                                    $this->expectedImpressionEventParams['visitors'][0]['snapshots'][0];
+        $this->expectedImpressionEventParams['visitors'][0]['snapshots'][0]['events'][0] =
+        [
+            'entity_id'=> '5',
+            'timestamp'=> $this->timestamp,
+            'uuid'=> $this->uuid,
+            'key'=> 'campaign_activated'
+        ];
+        $expectedLogEvent = new LogEvent(
+            $this->expectedEventUrl,
+            $this->expectedImpressionEventParams,
+            $this->expectedEventHttpVerb,
+            $this->expectedEventHeaders
+        );
+
+        $logEvent = $this->eventBuilder->createImpressionEvent(
+            $this->config,
+            '122235',
+            '177775',
+            'string_single_variable_feature',
+            'test_experiment_with_feature_rollout',
+            'experiment',
+            true,
+            $this->testUserId,
+            null
+        );
+        $logEvent = $this->fakeParamsToReconcile($logEvent);
+        $result = $this->areLogEventsEqual($expectedLogEvent, $logEvent);
+        $this->assertTrue($result[0], $result[1]);
+    }
+
     public function testCreateImpressionEventWithAttributesNoValue()
     {
         array_unshift(