fix(ForcedDecision): remove config-ready check from forced-decision apis (#236)

Co-authored-by: mnoman09 <[email protected]>

Author: mnoman09

src/Optimizely/OptimizelyUserContext.php

@@ -37,10 +37,6 @@ public function __construct(Optimizely $optimizelyClient, $userId, array $attrib
 
     public function setForcedDecision($context, $decision)
     {
-        // check if SDK is ready
-        if (!$this->optimizelyClient->isValid()) {
-            return false;
-        }
         $flagKey = $context->getFlagKey();
         if (!isset($flagKey)) {
             return false;
@@ -59,19 +55,11 @@ public function setForcedDecision($context, $decision)
 
     public function getForcedDecision($context)
     {
-        // check if SDK is ready
-        if (!$this->optimizelyClient->isValid()) {
-            return null;
-        }
         return $this->findForcedDecision($context);
     }
 
     public function removeForcedDecision($context)
     {
-        // check if SDK is ready
-        if (!$this->optimizelyClient->isValid()) {
-            return false;
-        }
         $index = $this->findExistingRuleAndFlagKey($context);
         if ($index != -1) {
             array_splice($this->forcedDecisions, $index, 1);
@@ -82,11 +70,6 @@ public function removeForcedDecision($context)
 
     public function removeAllForcedDecisions()
     {
-        // check if SDK is ready
-        if (!$this->optimizelyClient->isValid()) {
-            return false;
-        }
-
         $this->forcedDecisions = [];
         return true;
     }

tests/OptimizelyUserContextTest.php

@@ -264,31 +264,6 @@ public function testJsonSerialize()
 
     // Forced decision tests
 
-    public function testForcedDecisionInvalidDatafileReturnStatus()
-    {
-        $userId = 'test_user';
-        $attributes = [ "browser" => "chrome"];
-
-        $invalidOptlyObject = new Optimizely("Invalid datafile");
-
-        $optUserContext = new OptimizelyUserContext($invalidOptlyObject, $userId, $attributes);
-
-        $context = new OptimizelyDecisionContext("flag1", "targeted_delivery");
-        $decision = new OptimizelyForcedDecision("variation1");
-        
-        $setForcedDecision = $optUserContext->setForcedDecision($context, $decision);
-        $this->assertFalse($setForcedDecision);
-
-        $getForcedDecision = $optUserContext->getForcedDecision($context);
-        $this->assertNull($getForcedDecision);
-
-        $removeForcedDecision = $optUserContext->removeForcedDecision($context);
-        $this->assertFalse($removeForcedDecision);
-
-        $removeAllForcedDecision = $optUserContext->removeAllForcedDecisions();
-        $this->assertFalse($removeAllForcedDecision);
-    }
-
     public function testForcedDecisionValidDatafileReturnStatus()
     {
         $userId = 'test_user';