Skip to content

Conversation

raju-opti
Copy link
Contributor

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a typo in the Node.js implementation where clientEnging was misspelled instead of clientEngine, and adds proper TypeScript typing by importing and using the OptimizelyFactoryConfig type.

  • Fixed typo: clientEngingclientEngine in the Node.js configuration
  • Added proper TypeScript typing for configuration objects in both React Native and Node.js implementations
  • Imported OptimizelyFactoryConfig type to ensure type safety

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lib/index.react_native.ts Added OptimizelyFactoryConfig import and type annotation for rnConfig
lib/index.node.ts Added OptimizelyFactoryConfig import, type annotation for nodeConfig, and fixed clientEnging typo

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@coveralls
Copy link

Coverage Status

coverage: 78.76%. remained the same
when pulling 78c8ce6 on raju/typo_fix
into 99a4ca7 on master.

@raju-opti raju-opti merged commit e779889 into master Oct 14, 2025
17 of 19 checks passed
@raju-opti raju-opti deleted the raju/typo_fix branch October 14, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants