-
Notifications
You must be signed in to change notification settings - Fork 20
[FSSDK-11450] experimentId + variationId to decision notification listener #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
junaed-optimizely
merged 6 commits into
master
from
junaed/fssdk-11450-netspring-integration
Jun 18, 2025
+63
−49
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3a74053
pipeline test
junaed-optimizely 32581d2
notification payload update
junaed-optimizely 80c9067
readme update
junaed-optimizely 5e10b14
whitespace fix
junaed-optimizely cef0bbd
whitespace fix
junaed-optimizely 7901cb6
pipeline fix
junaed-optimizely File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unchanged files with check annotations Beta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var deliveryRules = | ||
GetDeliveryRules(featureFlag.Id, rollout.Experiments, projectConfig); | ||
var optimizelyFeature = new OptimizelyFeature(featureFlag.Id, | ||
Check warning on line 278 in OptimizelySDK/OptlyConfig/OptimizelyConfigService.cs
|
||
featureFlag.Key, | ||
experimentRules, | ||
deliveryRules, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
} | ||
#endif | ||
public static Optimizely NewDefaultInstance(string sdkKey) | ||
{ | ||
return NewDefaultInstance(sdkKey, null); | ||
} | ||
#if !NET40 && !NET35 | ||
public static Optimizely NewDefaultInstance(string sdkKey, string fallback, | ||
string datafileAuthToken | ||
) | ||
{ | ||
errorHandler, logger, eventProcessor: eventProcessor); | ||
} | ||
#endif | ||
public static Optimizely NewDefaultInstance(string sdkKey, string fallback) | ||
{ | ||
var logger = OptimizelyLogger ?? new DefaultLogger(); | ||
var errorHandler = new DefaultErrorHandler(logger, false); | ||
errorHandler, logger, eventProcessor: eventProcessor); | ||
} | ||
public static Optimizely NewDefaultInstance(ProjectConfigManager configManager, | ||
NotificationCenter notificationCenter = null, IEventDispatcher eventDispatcher = null, | ||
IErrorHandler errorHandler = null, ILogger logger = null, | ||
UserProfileService userprofileService = null, EventProcessor eventProcessor = null | ||
return new Optimizely(configManager, notificationCenter, eventDispatcher, logger, | ||
errorHandler, userprofileService, eventProcessor, null, odpManager); | ||
#else | ||
return new Optimizely(configManager, notificationCenter, eventDispatcher, logger, | ||
errorHandler, userprofileService, eventProcessor); | ||
#endif | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
private List<string> QualifiedSegments; | ||
// Optimizely object to be used. | ||
private Optimizely Optimizely; | ||
/// <summary> | ||
/// Determine if User Context has already been disposed | ||
private ForcedDecisionsStore ForcedDecisionsStore { get; set; } | ||
public OptimizelyUserContext(Optimizely optimizely, string userId, | ||
UserAttributes userAttributes, IErrorHandler errorHandler, ILogger logger | ||
) : this(optimizely, userId, userAttributes, null, null, errorHandler, logger) { } | ||
public OptimizelyUserContext(Optimizely optimizely, string userId, | ||
UserAttributes userAttributes, ForcedDecisionsStore forcedDecisionsStore, | ||
IErrorHandler errorHandler, ILogger logger | ||
) : this(optimizely, userId, userAttributes, forcedDecisionsStore, null, errorHandler, | ||
logger) | ||
{ } | ||
public OptimizelyUserContext(Optimizely optimizely, string userId, | ||
UserAttributes userAttributes, ForcedDecisionsStore forcedDecisionsStore, | ||
List<string> qualifiedSegments, IErrorHandler errorHandler, ILogger logger | ||
#if USE_ODP | ||
/// Returns Optimizely instance associated with the UserContext. | ||
/// </summary> | ||
/// <returns> Optimizely instance.</returns> | ||
public virtual Optimizely GetOptimizely() | ||
{ | ||
return Optimizely; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.