Skip to content

[FSSDK-11077] clean up travis #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 5, 2025
+7 −15
Merged

[FSSDK-11077] clean up travis #379

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6824376
clean up travis
jaeopt Jan 28, 2025
47d616c
clean up travis
jaeopt Feb 28, 2025
8196ba3
Trigger checks
jaeopt Mar 3, 2025
04afc2f
use local branch
jaeopt Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/csharp.yml
View file
Original file line number Diff line number Diff line change
@@ -103,17 +103,15 @@ jobs:
integration_tests:
name: Run Integration Tests
needs: [ netFrameworksAndUnitTest, netStandard16, netStandard20 ]
uses: optimizely/csharp-sdk/.github/workflows/integration_test.yml@master
uses: optimizely/csharp-sdk/.github/workflows/integration_test.yml@jae/FSSDK-11077
secrets:
CI_USER_TOKEN: ${{ secrets.CI_USER_TOKEN }}
TRAVIS_COM_TOKEN: ${{ secrets.TRAVIS_COM_TOKEN }}

fullstack_production_suite:
name: Run Performance Tests
needs: [ netFrameworksAndUnitTest, netStandard16, netStandard20 ]
uses: optimizely/csharp-sdk/.github/workflows/integration_test.yml@master
uses: optimizely/csharp-sdk/.github/workflows/integration_test.yml@jae/FSSDK-11077
with:
FULLSTACK_TEST_REPO: ProdTesting
secrets:
CI_USER_TOKEN: ${{ secrets.CI_USER_TOKEN }}
TRAVIS_COM_TOKEN: ${{ secrets.TRAVIS_COM_TOKEN }}
11 changes: 3 additions & 8 deletions .github/workflows/integration_test.yml
View file
Original file line number Diff line number Diff line change
@@ -9,8 +9,6 @@ on:
secrets:
CI_USER_TOKEN:
required: true
TRAVIS_COM_TOKEN:
required: true
jobs:
test:
runs-on: ubuntu-latest
@@ -19,23 +17,21 @@ jobs:
with:
# You should create a personal access token and store it in your repository
token: ${{ secrets.CI_USER_TOKEN }}
repository: 'optimizely/travisci-tools'
path: 'home/runner/travisci-tools'
repository: 'optimizely/ci-helper-tools'
path: 'home/runner/ci-helper-tools'
ref: 'master'
- name: set SDK Branch if PR
env:
HEAD_REF: ${{ github.head_ref }}
if: ${{ github.event_name == 'pull_request' }}
run: |
echo "SDK_BRANCH=$HEAD_REF" >> $GITHUB_ENV
echo "TRAVIS_BRANCH=$HEAD_REF" >> $GITHUB_ENV
- name: set SDK Branch if not pull request
env:
REF_NAME: ${{ github.ref_name }}
if: ${{ github.event_name != 'pull_request' }}
run: |
echo "SDK_BRANCH=$REF_NAME" >> $GITHUB_ENV
echo "TRAVIS_BRANCH=$REF_NAME" >> $GITHUB_ENV
- name: Trigger build
env:
SDK: csharp
@@ -51,9 +47,8 @@ jobs:
PULL_REQUEST_SHA: ${{ github.event.pull_request.head.sha }}
PULL_REQUEST_NUMBER: ${{ github.event.pull_request.number }}
UPSTREAM_SHA: ${{ github.sha }}
TOKEN: ${{ secrets.TRAVIS_COM_TOKEN }}
EVENT_MESSAGE: ${{ github.event.message }}
HOME: 'home/runner'
run: |
echo "$GITHUB_CONTEXT"
home/runner/travisci-tools/trigger-script-with-status-update.sh
home/runner/ci-helper-tools/trigger-script-with-status-update.sh
3 changes: 1 addition & 2 deletions OptimizelySDK.DemoApp/Scripts/README.md
View file
Original file line number Diff line number Diff line change
@@ -7,7 +7,6 @@
</p>

<p align="center">
<a href="https://travis-ci.org/FezVrasta/popper.js/branches" target="_blank"><img src="https://travis-ci.org/FezVrasta/popper.js.svg?branch=master" alt="Build Status"/></a>
<img src="http://img.badgesize.io/https://unpkg.com/popper.js/dist/popper.min.js?compression=gzip" alt="Stable Release Size"/>
<a href="https://www.bithound.io/github/FezVrasta/popper.js"><img src="https://www.bithound.io/github/FezVrasta/popper.js/badges/score.svg" alt="bitHound Overall Score"></a>
<a href="https://codeclimate.com/github/FezVrasta/popper.js/coverage"><img src="https://codeclimate.com/github/FezVrasta/popper.js/badges/coverage.svg" alt="Istanbul Code Coverage"/></a>
@@ -34,7 +33,7 @@ to make it possible to position it near a given reference element.

The engine is completely modular and most of its features are implemented as **modifiers**
(similar to middlewares or plugins).
The whole code base is written in ES2015 and its features are automatically tested on real browsers thanks to [SauceLabs](https://saucelabs.com/) and [TravisCI](https://travis-ci.org/).
The whole code base is written in ES2015 and its features are automatically tested on real browsers thanks to [SauceLabs](https://saucelabs.com/).

Popper.js has zero dependencies. No jQuery, no LoDash, nothing.
It's used by big companies like [Twitter in Bootstrap v4](https://getbootstrap.com/), [Microsoft in WebClipper](https://github.com/OneNoteDev/WebClipper) and [Atlassian in AtlasKit](https://aui-cdn.atlassian.com/atlaskit/registry/).
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Optimizely C# SDK
![Semantic](https://img.shields.io/badge/sem-ver-lightgrey.svg?style=plastic)
[![Build Status](https://travis-ci.org/optimizely/csharp-sdk.svg?branch=master)](https://travis-ci.org/optimizely/csharp-sdk)
![CI](https://github.com/optimizely/csharp-sdk/actions/workflows/csharp.yml/badge.svg?branch=master)
[![NuGet](https://img.shields.io/nuget/v/Optimizely.SDK.svg?style=plastic)](https://www.nuget.org/packages/Optimizely.SDK/)
[![Apache 2.0](https://img.shields.io/github/license/nebula-plugins/gradle-extra-configurations-plugin.svg)](http://www.apache.org/licenses/LICENSE-2.0)

Unchanged files with check annotations Beta

View file
OptimizelySDK/OptimizelyFactory.cs
}
#endif
public static Optimizely NewDefaultInstance(string sdkKey)

Check warning on line 149 in OptimizelySDK/OptimizelyFactory.cs

GitHub Actions / Build Standard 1.6 

'Optimizely' is obsolete: 'Net standard 1.6 SDK support is deprecated, use Net standard 2.0 or above'
{
return NewDefaultInstance(sdkKey, null);
}
#if !NET40 && !NET35
public static Optimizely NewDefaultInstance(string sdkKey, string fallback,

Check warning on line 154 in OptimizelySDK/OptimizelyFactory.cs

GitHub Actions / Build Standard 1.6 

'Optimizely' is obsolete: 'Net standard 1.6 SDK support is deprecated, use Net standard 2.0 or above'
string datafileAuthToken
)
{
errorHandler, logger, eventProcessor: eventProcessor);
}
#endif
public static Optimizely NewDefaultInstance(string sdkKey, string fallback)

Check warning on line 189 in OptimizelySDK/OptimizelyFactory.cs

GitHub Actions / Build Standard 1.6 

'Optimizely' is obsolete: 'Net standard 1.6 SDK support is deprecated, use Net standard 2.0 or above'
{
var logger = OptimizelyLogger ?? new DefaultLogger();
var errorHandler = new DefaultErrorHandler(logger, false);
errorHandler, logger, eventProcessor: eventProcessor);
}
public static Optimizely NewDefaultInstance(ProjectConfigManager configManager,

Check warning on line 221 in OptimizelySDK/OptimizelyFactory.cs

GitHub Actions / Build Standard 1.6 

'Optimizely' is obsolete: 'Net standard 1.6 SDK support is deprecated, use Net standard 2.0 or above'
NotificationCenter notificationCenter = null, IEventDispatcher eventDispatcher = null,
IErrorHandler errorHandler = null, ILogger logger = null,
UserProfileService userprofileService = null, EventProcessor eventProcessor = null
return new Optimizely(configManager, notificationCenter, eventDispatcher, logger,
errorHandler, userprofileService, eventProcessor, null, odpManager);
#else
return new Optimizely(configManager, notificationCenter, eventDispatcher, logger,

Check warning on line 235 in OptimizelySDK/OptimizelyFactory.cs

GitHub Actions / Build Standard 1.6 

'Optimizely' is obsolete: 'Net standard 1.6 SDK support is deprecated, use Net standard 2.0 or above'
errorHandler, userprofileService, eventProcessor);
#endif
View file
OptimizelySDK/OptimizelyUserContext.cs
private List<string> QualifiedSegments;
// Optimizely object to be used.
private Optimizely Optimizely;

Check warning on line 55 in OptimizelySDK/OptimizelyUserContext.cs

GitHub Actions / Build Standard 1.6 

'Optimizely' is obsolete: 'Net standard 1.6 SDK support is deprecated, use Net standard 2.0 or above'
/// <summary>
/// Determine if User Context has already been disposed
private ForcedDecisionsStore ForcedDecisionsStore { get; set; }
public OptimizelyUserContext(Optimizely optimizely, string userId,

Check warning on line 64 in OptimizelySDK/OptimizelyUserContext.cs

GitHub Actions / Build Standard 1.6 

'Optimizely' is obsolete: 'Net standard 1.6 SDK support is deprecated, use Net standard 2.0 or above'
UserAttributes userAttributes, IErrorHandler errorHandler, ILogger logger
) : this(optimizely, userId, userAttributes, null, null, errorHandler, logger) { }
public OptimizelyUserContext(Optimizely optimizely, string userId,

Check warning on line 68 in OptimizelySDK/OptimizelyUserContext.cs

GitHub Actions / Build Standard 1.6 

'Optimizely' is obsolete: 'Net standard 1.6 SDK support is deprecated, use Net standard 2.0 or above'
UserAttributes userAttributes, ForcedDecisionsStore forcedDecisionsStore,
IErrorHandler errorHandler, ILogger logger
) : this(optimizely, userId, userAttributes, forcedDecisionsStore, null, errorHandler,
logger)
{ }
public OptimizelyUserContext(Optimizely optimizely, string userId,

Check warning on line 75 in OptimizelySDK/OptimizelyUserContext.cs

GitHub Actions / Build Standard 1.6 

'Optimizely' is obsolete: 'Net standard 1.6 SDK support is deprecated, use Net standard 2.0 or above'
UserAttributes userAttributes, ForcedDecisionsStore forcedDecisionsStore,
List<string> qualifiedSegments, IErrorHandler errorHandler, ILogger logger
#if USE_ODP
/// Returns Optimizely instance associated with the UserContext.
/// </summary>
/// <returns> Optimizely instance.</returns>
public virtual Optimizely GetOptimizely()

Check warning on line 111 in OptimizelySDK/OptimizelyUserContext.cs

GitHub Actions / Build Standard 1.6 

'Optimizely' is obsolete: 'Net standard 1.6 SDK support is deprecated, use Net standard 2.0 or above'
{
return Optimizely;
}
View file
OptimizelySDK/Optimizely.cs
try
{
#if USE_ODP
InitializeComponents(eventDispatcher, logger, errorHandler, userProfileService,

Check warning on line 144 in OptimizelySDK/Optimizely.cs

GitHub Actions / Build Standard 2.0 

'Optimizely.InitializeComponents(IEventDispatcher, ILogger, IErrorHandler, UserProfileService, NotificationCenter, EventProcessor, OptimizelyDecideOption[], IOdpManager)' is obsolete

Check warning on line 144 in OptimizelySDK/Optimizely.cs

GitHub Actions / Build Standard 2.0 

'Optimizely.InitializeComponents(IEventDispatcher, ILogger, IErrorHandler, UserProfileService, NotificationCenter, EventProcessor, OptimizelyDecideOption[], IOdpManager)' is obsolete
null, eventProcessor, defaultDecideOptions, odpManager);
#else
InitializeComponents(eventDispatcher, logger, errorHandler, userProfileService,
ProjectConfigManager = configManager;
#if USE_ODP
InitializeComponents(eventDispatcher, logger, errorHandler, userProfileService,

Check warning on line 212 in OptimizelySDK/Optimizely.cs

GitHub Actions / Build Standard 2.0 

'Optimizely.InitializeComponents(IEventDispatcher, ILogger, IErrorHandler, UserProfileService, NotificationCenter, EventProcessor, OptimizelyDecideOption[], IOdpManager)' is obsolete

Check warning on line 212 in OptimizelySDK/Optimizely.cs

GitHub Actions / Build Standard 2.0 

'Optimizely.InitializeComponents(IEventDispatcher, ILogger, IErrorHandler, UserProfileService, NotificationCenter, EventProcessor, OptimizelyDecideOption[], IOdpManager)' is obsolete
notificationCenter, eventProcessor, defaultDecideOptions, odpManager);
var projectConfig = ProjectConfigManager.CachedProjectConfig;
View file
OptimizelySDK/OptlyConfig/OptimizelyConfigService.cs
var deliveryRules =
GetDeliveryRules(featureFlag.Id, rollout.Experiments, projectConfig);
var optimizelyFeature = new OptimizelyFeature(featureFlag.Id,

Check warning on line 278 in OptimizelySDK/OptlyConfig/OptimizelyConfigService.cs

GitHub Actions / Build Standard 2.0 

'OptimizelyFeature.OptimizelyFeature(string, string, List<OptimizelyExperiment>, List<OptimizelyExperiment>, IDictionary<string, OptimizelyExperiment>, IDictionary<string, OptimizelyVariable>)' is obsolete

Check warning on line 278 in OptimizelySDK/OptlyConfig/OptimizelyConfigService.cs

GitHub Actions / Build Standard 2.0 

'OptimizelyFeature.OptimizelyFeature(string, string, List<OptimizelyExperiment>, List<OptimizelyExperiment>, IDictionary<string, OptimizelyExperiment>, IDictionary<string, OptimizelyVariable>)' is obsolete
featureFlag.Key,
experimentRules,
deliveryRules,