Skip to content

Logging improvement #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Logging improvement #288

wants to merge 2 commits into from

Conversation

deepthawtz
Copy link

Summary

  • Stop logging SDK keys. As many others also do we collect logs for search and don't want these keys to be viewable
  • Log incoming API requests. Yes, there is the /metrics endpoint but we want to also see what reqs the agent is handling via logs using our existing tools.

I'm open to suggestions, e.g., if we only want to make the http logger optional (via config).

@deepthawtz deepthawtz closed this Oct 13, 2020
@deepthawtz deepthawtz reopened this Oct 13, 2020
@deepthawtz
Copy link
Author

CI tests failing at

$ ./scripts/pull_travis_ci_tools.sh
~/travisci-tools ~/build/optimizely/agent
Initialized empty Git repository in /home/travis/travisci-tools/.git/
remote: Repository not found.
fatal: Authentication failed for 'https://@github.com/optimizely/travisci-tools.git/'

@Tamara-Barum
Copy link

Internal ticket created for tracking: FSSDK-9410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepthawtz @Tamara-Barum