Fixes AngularJS mentions as migration is complete#516
Fixes AngularJS mentions as migration is complete#516rohanmalhotracodes wants to merge 8 commits intooppia:developfrom
Conversation
|
@HardikGoyal2003 @jayam04 gentle reminder, thanks and apologies for taking your time. |
HardikGoyal2003
left a comment
There was a problem hiding this comment.
@rohanmalhotracodes Please remove the Angular-migration page also.
|
I think this file also needs to be updated: https://github.com/oppia/oppia/wiki/Coding-style-guide |
HardikGoyal2003
left a comment
There was a problem hiding this comment.
Also try looking into this: https://github.com/search?q=repo%3Aoppia%2Foppia+mainpage&type=wikis
Migration is totally complete
link removal as page does not exist
fixed mainpage html which is not used anymore
This reverts commit e9f214f.
There was a problem hiding this comment.
Addressed the issues stated by sir
@HardikGoyal2003 PTAL
|
@rohanmalhotracodes We need to keep this PR on the stand by for some time, as we are in the process of removing some remaining architecture of AngularJS, where these docs will be needed to refer. So for now, let this PR be open, once we are ready to remove it, I will ping you. Thanks! |
|
Understood. Thanks. |
I’ve made the following AngularJS cleanup updates related to this issue:
Learning-Resources.mdReplaced the old “AngularJS/Angular” wording with “Angular”, and updated the learning resources so they point only to Angular material.
Frontend-tests.mdRemoved AngularJS-specific references and examples (including AngularJS-only terminology and testing guidance), and updated the document so it consistently uses Angular terminology and Angular testing patterns.
Overview-of-the-Oppia-codebase.mdUpdated the frontend overview to describe the frontend as Angular-based, removed AngularJS-specific comparison language, and simplified the MVC mapping so it uses Angular terminology only.
I also wanted to mention that I think
Angular-Migration.mdmay no longer be necessary and could potentially be removed since the migration is now considered complete.Fix #511