Feature Request: Added documentation for installation of graphicsmagick#455
Open
Ashu463 wants to merge 1 commit intooppia:developfrom
Open
Feature Request: Added documentation for installation of graphicsmagick#455Ashu463 wants to merge 1 commit intooppia:developfrom
Ashu463 wants to merge 1 commit intooppia:developfrom
Conversation
Author
|
@U8NWXD could you PTAL here. |
Closed
5 tasks
U8NWXD
requested changes
May 19, 2025
| * [Notes on installation on Arch Linux systems](#notes-on-installation-on-arch-linux-systems) | ||
| * [Changes to installation prerequisites](#changes-to-installation-prerequisites) | ||
| * [Changes to the virtual environment setup](#changes-to-the-virtual-environment-setup) | ||
| - [Table of Contents](#table-of-contents) |
Member
There was a problem hiding this comment.
We exclude the table of contents entry from the table of contents
Comment on lines
+43
to
+46
| - For MacOS: | ||
| ``` | ||
| brew install graphicsmagick | ||
| ``` |
Member
There was a problem hiding this comment.
The macOS installation instructions should go in our separate macOS installation guide
Comment on lines
+37
to
+42
| 3. Install GraphicsMagick to enable local image compression and ensure tests run successfully. Follow the appropriate steps below based on your operating system: | ||
| - For Ubuntu/Debian systems: | ||
| ``` | ||
| sudo apt-get update | ||
| sudo apt-get install graphicsmagick | ||
| ``` |
Member
There was a problem hiding this comment.
why not just add graphicsmagick to the packages installed in step 1 and to scripts/install_prerequisites.sh? that seems simpler
Comment on lines
+47
to
+50
| After installation, verify that GraphicsMagick is correctly installed by running: | ||
| ``` | ||
| gm version | ||
| ``` |
Member
There was a problem hiding this comment.
I think you can skip this, as we don't confirm installation of any of our other prerequisites. Dropping this will also let you more easily fold this change into step 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added documentation for installation of graphicsmagick, which is discussed in this oppia/oppia#21694 PR several times.
In this PR I added installation steps for linux and mac users only. I'll add installation steps for windows soon.
Thanks.