Align WithElements typing with runtime naming

[myabc]

Ticket

N/A — internal architecture review of this library.

Stacked on #6 (vitest browser-mode migration): the branch is rebased onto code-maintenance/vitest, so this PR's file list shows #6's commit until #6 lands on main (GitHub's stack feature blocks retargeting the base). Chain: #6 ← this ← #2 ← #4.

What are you trying to accomplish?

Give the element-naming rule (static elements key → xElement/xElements/hasXElement + attribute-override suffix) a single owner. It was spread across helpers.ts, blessing.ts, and types.ts — and the type already disagreed with the runtime: WithElements<{menu_item: string}> produced menu_itemElement vs runtime menuItemElement (documented as a README caveat instead of fixed). Different keys could also silently collide on generated names (foo/_foo → hasFooElement).

What approach did you choose and why?

• New src/element-definition.ts owns the rule at runtime (elementDefinition, mergeElementDefinitions) and type level (Camelize<K> mirroring the camelize regex exactly). String helpers become private; types.ts folded in.
• WithElements now camelizes like the runtime — keys pass verbatim. Compile-surface breaking for snake_case-typed consumers (changeset: minor).
• Cross-key name collisions warn; later definition wins per property (previous Object.assign semantics). Colliding names get a union type, forcing callers to narrow — an intersection would hide the pathology.
• Acronym dasherization (htmlURL → html-u-r-l) locked in by tests, Stimulus-compatible.
• New typecheck script gates test/types.test-d.ts in CI; build cleans dist/ first. CONTEXT.md records glossary + decisions.

Verification: bun test 40 pass, bun run typecheck clean, bun run build clean.

Merge checklist

• Added/updated tests
• Lookbook docs n/a — npm library; README + CONTEXT.md updated
• Tested major browsers n/a — no browser-dependent behavior

[Copilot]

Pull request overview

This PR centralizes the static elements naming rule (runtime + TypeScript) into a single module, aligns WithElements typing with the runtime camelization behavior, and adds CI/typecheck coverage plus characterization tests around collisions and acronym dasherization.

Changes:

• Introduces src/element-definition.ts as the single owner for element accessor naming (runtime) and Camelize/WithElements (types).
• Updates the blessing implementation to consume merged element definitions and warn on cross-key generated-name collisions.
• Adds type-level assertions + CI typecheck, expands tests, and updates docs/changeset accordingly.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test/types.test-d.ts	Adds tsc-checked type-level assertions for Camelize/WithElements.
test/helpers.test.ts	Removes tests for string helpers now made private/relocated.
test/element-definition.test.ts	Adds runtime tests for naming, sample-table lockstep, and collision warnings.
test/blessing.test.ts	Adds integration/characterization tests for acronym overrides and collision behavior.
src/types.ts	Removes old WithElements typing (moved/rewritten).
src/helpers.ts	Removes exported string transforms; keeps readInheritableStaticObjectPairs.
src/element-definition.ts	New module implementing runtime naming + type-level Camelize/WithElements.
src/blessing.ts	Switches to mergeElementDefinitions + ElementDefinition to generate properties.
README.md	Updates documentation to reflect runtime-aligned camelization in WithElements.
package.json	Cleans dist/ before build; adds typecheck script.
index.ts	Re-exports WithElements from the new module.
CONTEXT.md	Records glossary + decisions (acronym lock-in, collision policy, type/runtime lockstep).
.github/workflows/test.yml	Adds bun run typecheck step in CI.
.changeset/warm-planes-refactor.md	Documents the typing alignment + collision warning behavior as a minor change.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.