Make some files ready for frozen string literals #18041
Open
+45
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodysNightmare
force-pushed
the
frozen-string-safety
branch
2 times, most recently
from
2312d0f to
4622c9b
Compare
During a previous test, added the frozen string literal comment to all Ruby files, to see how our codebase would react to that. The test run uncovered a few files that were trying to modify strings that originate from string literals. This commit is changed some of them to be safe under frozen string literals and freezes literals in the affected files.
NobodysNightmare
force-pushed
the
frozen-string-safety
branch
from
4622c9b to
c0d59d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a previous test (#18039), I added the frozen string literal comment to all Ruby files, to see how our codebase would react to that.
The test run uncovered a few files that were trying to modify strings that originate from string literals. This commit is changed some of them to be safe under frozen string literals and freezes literals in the affected files.