-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: add ignore-not-found for undeploy and uninstall to Makefile boiler plate #6842
base: master
Are you sure you want to change the base?
scripts: add ignore-not-found for undeploy and uninstall to Makefile boiler plate #6842
Conversation
f27a4d4
to
6366640
Compare
…boiler plate This avoid failure of any of these two commands if for some reason one or more of the kustomized resource is missing. Part of 5195 Signed-off-by: Samuel Gaist <[email protected]>
6366640
to
666ed4f
Compare
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/reopen |
@sgaist: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description of the change:
This PR adds the
--ignore-not-found
parameter to thekubectl
call when callingmake undeploy
andmake uninstall
.Motivation for the change:
This avoid the failure of either command if for some reason one or more of the kustomized resource is missing.
Part of #5195
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs