Skip to content

🌱 Disable FailForward bad resource e2e #3572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

perdasilva
Copy link
Collaborator

@perdasilva perdasilva commented May 7, 2025

Description of the change:

While investigating the FailForward e2e test flakyness, I've discovered we have a hot loop in the CSV state graph where non-terminal errors seem to be retried forever. For the FF e2e, there's a bundle with a bad deployment name. This error was not being marked as terminal. While the csv hot looped: Pending -> InstallReady -> Failed -> Pending -> ..., the test detected the failed state and created the catalog with the fixed bundle, which created the flake as the resolved would fail resolution due to non-referenced csvs =S

Bug has been filed here: #3573

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2025
Copy link

openshift-ci bot commented May 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@perdasilva perdasilva changed the title Make bad resource failures terminal 🐛 Make bad resource failures terminal May 7, 2025
@perdasilva perdasilva force-pushed the fix-ff-e2e branch 27 times, most recently from 850c9e3 to b302cf5 Compare May 7, 2025 11:12
@perdasilva perdasilva force-pushed the fix-ff-e2e branch 14 times, most recently from 211edbc to a81b007 Compare May 7, 2025 11:57
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva changed the title 🐛 Make bad resource failures terminal 🌱 : Disable FailForward bad resource e2e May 9, 2025
@perdasilva perdasilva marked this pull request as ready for review May 9, 2025 07:50
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2025
@openshift-ci openshift-ci bot requested review from camilamacedo86 and dtfranz May 9, 2025 07:50
@perdasilva perdasilva changed the title 🌱 : Disable FailForward bad resource e2e 🌱 Disable FailForward bad resource e2e May 9, 2025
@perdasilva perdasilva enabled auto-merge May 9, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant