-
Notifications
You must be signed in to change notification settings - Fork 64
🌱 migrate from github.com/everettraven/crd-diff to sigs.k8s.io/crdify #2010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🌱 migrate from github.com/everettraven/crd-diff to sigs.k8s.io/crdify #2010
Conversation
Signed-off-by: Bryce Palmer <[email protected]>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
validations: | ||
- name: enum | ||
enforcement: Error | ||
configuration: | ||
additionPolicy: Allow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewers: This is technically a less restrictive config than existed before, but IIRC it was planned to add new enum values in various places during continued development of OLMv1 so this felt reasonable to include.
If you want to maintain the strictest possible configuration, the options here could be to:
- Remove the use of a configuration file as
crdify
defaults to the strictest possible analysis - Switch
additionPolicy
toDisallow
(keeps the config file around)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2010 +/- ##
=======================================
Coverage 69.17% 69.17%
=======================================
Files 79 79
Lines 7037 7037
=======================================
Hits 4868 4868
Misses 1887 1887
Partials 282 282
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@everettraven because this pulls in go1.24, we won't be able to merge it T_T |
@perdasilva I noted that in a Slack message I sent to the olm-dev channel :) I imagine that you'll be bumping to go 1.24 at some point? I'm happy for this to be held until that point. I don't think this is urgent |
Description
This updates the usage of
github.com/everettraven/crd-diff
in CI tosigs.k8s.io/crdify
as the project has now been donated under the umbrella of sig-api-machinery.Reviewer Checklist