Skip to content

Conversation

acornett21
Copy link
Contributor

@acornett21 acornett21 commented Sep 8, 2025

Description of the change:

  • update controller logic to take into account version in GroupVersionKind, to allow for multiple controller registrations for various versions of a CRD.

Motivation for the change:

Testing:

kubectl logs foo-operator-5dc78f4f54-trjhr
{"level":"info","ts":"2025-09-08T18:51:20Z","logger":"cmd","msg":"Version","Go Version":"go1.24.4","GOOS":"linux","GOARCH":"amd64","ansible-operator":"v1.39.0-10-g69eec07b-dirty","commit":"69eec07b3ae855719c1b0c32233aa83e16ae84b5"}
{"level":"info","ts":"2025-09-08T18:51:20Z","logger":"cmd","msg":"Environment variable OPERATOR_NAME has been deprecated, use --leader-election-id instead."}
{"level":"info","ts":"2025-09-08T18:51:20Z","logger":"cmd","msg":"Watching all namespaces"}
{"level":"info","ts":"2025-09-08T18:51:20Z","logger":"watches","msg":"Environment variable not set; using default value","envVar":"ANSIBLE_VERBOSITY_FOO_EXAMPLE_COM","default":2}
{"level":"info","ts":"2025-09-08T18:51:20Z","logger":"watches","msg":"Environment variable not set; using default value","envVar":"ANSIBLE_VERBOSITY_FOO_EXAMPLE_COM","default":2}
{"level":"info","ts":"2025-09-08T18:51:20Z","logger":"ansible-controller","msg":"Watching resource","Options.Group":"example.com","Options.Version":"v1alpha1","Options.Kind":"Foo"}
{"level":"info","ts":"2025-09-08T18:51:20Z","logger":"ansible-controller","msg":"Watching resource","Options.Group":"example.com","Options.Version":"v1","Options.Kind":"Foo"}
{"level":"info","ts":"2025-09-08T18:51:20Z","logger":"proxy","msg":"Starting to serve","Address":"127.0.0.1:8888"}
{"level":"info","ts":"2025-09-08T18:51:20Z","logger":"apiserver","msg":"Starting to serve metrics listener","Address":"localhost:5050"}
{"level":"info","ts":"2025-09-08T18:51:20Z","logger":"controller-runtime.metrics","msg":"Starting metrics server"}
{"level":"info","ts":"2025-09-08T18:51:20Z","logger":"controller-runtime.metrics","msg":"Serving metrics server","bindAddress":":8443","secure":false}
{"level":"info","ts":"2025-09-08T18:51:20Z","msg":"starting server","name":"health probe","addr":"[::]:6789"}
{"level":"info","ts":"2025-09-08T18:51:20Z","msg":"Starting EventSource","controller":"foo-v1alpha1-controller","source":"kind source: *unstructured.Unstructured"}
{"level":"info","ts":"2025-09-08T18:51:20Z","msg":"Starting EventSource","controller":"foo-v1-controller","source":"kind source: *unstructured.Unstructured"}
{"level":"info","ts":"2025-09-08T18:51:21Z","msg":"Starting Controller","controller":"foo-v1alpha1-controller"}
{"level":"info","ts":"2025-09-08T18:51:21Z","msg":"Starting workers","controller":"foo-v1alpha1-controller","worker count":16}
{"level":"info","ts":"2025-09-08T18:51:21Z","msg":"Starting Controller","controller":"foo-v1-controller"}
{"level":"info","ts":"2025-09-08T18:51:21Z","msg":"Starting workers","controller":"foo-v1-controller","worker count":16}

@acornett21 acornett21 merged commit 476f01a into operator-framework:main Sep 8, 2025
9 checks passed
@acornett21 acornett21 deleted the fix_154 branch September 8, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Startup fails - controller name conflict when watching multiple versions of the same Kind
1 participant