[fix] Disconnect websocket on page reload to prevent missed notificat… #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions openwisp#264 When users click "Save" or "Save and Continue", the page reloads and closes the websocket connection. If a background task completes during this reload, the notification is lost because there's no active websocket connection to receive it. This change explicitly disconnects the websocket on beforeunload, ensuring the server knows the client is unavailable. When the page reloads and the websocket reconnects, any queued notifications will be delivered properly. Fixes openwisp#264
Adityashandilya555
force-pushed
the
fix/notification-toast-persist-on-reload
branch
from
e6e571d to
a0990d1
Compare
|
i have fixed the qa formatting issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users click "Save" or "Save and Continue", the page reloads and closes the websocket connection. If a background task completes during this reload, the notification is lost because there's no active websocket connection to receive it.
Fixes #264
Checklist
Reference to Existing Issue
Closes #264 .
Description of Changes
Added websocket disconnection in the
beforeunloadevent handler. Thisensures the server knows the client is unavailable and will queue notifications.
When the page reloads and the websocket reconnects, any queued notifications will be
delivered properly
Screenshot
Please include any relevant screenshots.