-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Improve UX of the Notifications Module #344
Conversation
@Dhanus3133 can you ensure that the coverage does not decrease for these files:
|
@pandafy For the coverage missing on base/models.py openwisp-notifications/openwisp_notifications/base/models.py Lines 302 to 304 in b7dff78
Seems to be due to the defaults being set here openwisp-notifications/openwisp_notifications/tasks.py Lines 88 to 107 in 941982d
But if that's the case openwisp-notifications/openwisp_notifications/base/models.py Lines 308 to 310 in b7dff78
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflicts with master and squash commits so we have 1 commit for each feature/change.
I hope we can merge after this.
Closes #132 Closes #306 --------- Co-authored-by: Federico Capoano <[email protected]> Co-authored-by: Gagan Deep <[email protected]>
b20b0be
to
54c6b8d
Compare
Closes #110 Closes #148 Closes #255 --------- Co-authored-by: Federico Capoano <[email protected]> Co-authored-by: Gagan Deep <[email protected]>
Implements and closes #256 --------- Co-authored-by: Federico Capoano <[email protected]> Co-authored-by: Gagan Deep <[email protected]>
Closes #132
Closes #306
Closes #110
Closes #148
Closes #255