[change] Update tested versions #332
Conversation
Make these version changes: 1. Add Python 3.13. 2. Add Django 5.2 (currently in beta, [expected April](https://docs.djangoproject.com/en/5.2/releases/5.2/)). Also: 1. Declare the the Django version dependency in `setup.py`. 2. Update openwisp-utils to install from GitHub’s tarball URLs. The lack of suffix caused issues for me with [uv](https://docs.astral.sh/uv/) via [tox-uv](https://pypi.org/project/tox-uv/). 3. Drop parallel testing - it was slower for me, 2s versus 1s.
|
Sigh... the install step is broken on Python 3.13 because coveralls pins to Python <3.13 and hasn't removed that yet. Pending PR: TheKevJames/coveralls-python#542 . I didn't see this locally because I use tox with uv, via tox-uv. They deliberately ignore upper version bounds on Python: astral-sh/uv#4022 . Would you be interested in converting the testing to uv? It wouldn't take much more than installing tox-uv. |
There was a problem hiding this comment.
Thanks for working on this.
It seems CI action fails because coveralls doesn't support Python 3.13 yet and doesn't seem well maintained.
It can be a good idea to drop it, enforcing 100% test coverage using coverage report --fail-under=xx, like in this other PR https://github.com/kipe/pycron/pull/41/files
| django42: Django~=4.2.0 | ||
| django50: Django~=5.0.0 | ||
| django51: Django~=5.1.0 | ||
| django42: Django~=4.2a1 |
There was a problem hiding this comment.
I'm interested in the motivation to use alpha version of Django here
There was a problem hiding this comment.
The ~ means “compatible with”. It still picks the latest version, just from alpha onwards rather than the GA release onwards.
There was a problem hiding this comment.
Yes, I currently use ~= but usually starting with the first stable version (e.g. django~=4.2.0). I was curious about the motivation to include also alpha version (e.g. django~=4.2a1). What's the benefit?
Yes, will do |
There was a problem hiding this comment.
Hi @adamchainz PR title should be descriptive enough to know the changes done. Also, reference the issue in PR description and commit message. Do follow these guidelines:
https://openwisp.io/docs/dev/developer/contributing.html
| @@ -2,4 +2,4 @@ psycopg2~=2.9.10 | |||
| django-filter>=2.0 | |||
| contexttimer | |||
| # QA checks | |||
| openwisp-utils[qa] @ https://github.com/openwisp/openwisp-utils/tarball/1.2 | |||
| openwisp-utils[qa] @ git+https://github.com/openwisp/openwisp-utils@1.1.1 | |||
There was a problem hiding this comment.
Why this change is made? We shouldn't pin the version in test dependencies
| @@ -14,12 +15,13 @@ setenv = | |||
| DRFG_TEST_RUNNER=./tests/manage.py test | |||
| pytest: DRFG_TEST_RUNNER=-m pytest | |||
| commands = | |||
| coverage run {env:DRFG_TEST_RUNNER} {posargs:tests/django_restframework_gis_tests} --parallel | |||
| coverage run {env:DRFG_TEST_RUNNER} {posargs:tests/django_restframework_gis_tests} | |||
There was a problem hiding this comment.
Why this parallel flag is removed? Kindly follow the guidelines
https://openwisp.io/docs/dev/developer/contributing.html#avoiding-unnecessary-changes
Checklist
Reference to Existing Issue
n/a
Description of Changes
Make these version changes:
Also:
setup.py.Screenshot
n/a