Skip to content

[feature] Add factorial function which helps in calculating factorial… #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pushpitkamboj wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[feature] Add factorial function which helps in calculating factorial… #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pushpit/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,14 @@ def is_even(number: int) -> bool:
"""Check if a number is even."""
return number % 2 == 0

Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing blank line before function definition. According to PEP 8 and the existing code style in this file (see lines before greet, calculate_sum, and is_even), there should be two blank lines before the function definition, but there is only one.

Suggested change

Copilot uses AI. Check for mistakes.
def factorial(n: int) -> int:
"""Calculate the factorial of a number."""
if n == 0:
return 1
else:
return n * factorial(n - 1)
Comment on lines +19 to +23
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The factorial function lacks input validation for large numbers. Python's default recursion limit is typically around 1000, which means factorial(1000) will fail with a RecursionError. Consider adding a check for large inputs or implementing an iterative version to handle larger factorials more safely.

Suggested change
"""Calculate the factorial of a number."""
if n == 0:
return 1
else:
return n * factorial(n - 1)
"""Calculate the factorial of a non-negative integer.
Uses an iterative approach to avoid recursion limits.
"""
if n < 0:
raise ValueError("factorial() not defined for negative values")
result = 1
for i in range(2, n + 1):
result *= i
return result

Copilot uses AI. Check for mistakes.
Comment on lines +22 to +23
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary else statement after return. Since line 21 contains a return statement, the else on line 22 is redundant. The code on line 23 can be dedented to align with the if statement, which is more Pythonic and improves readability.

Suggested change
else:
return n * factorial(n - 1)
return n * factorial(n - 1)

Copilot uses AI. Check for mistakes.
Comment on lines +18 to +23
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The factorial function does not handle negative numbers. For negative input values, the function will cause infinite recursion and eventually crash with a RecursionError. Consider adding input validation to handle negative numbers appropriately, either by raising a ValueError or returning a specific value.

Copilot uses AI. Check for mistakes.

Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected. There are extra spaces at the end of this line, which violates PEP 8 style guidelines and can cause issues with version control systems.

Copilot uses AI. Check for mistakes.


def main():
"""Main function to run the program."""
Expand Down