Fix issues when the sql_mode includes the only_full_group_by setting. #2805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
force-pushed
the
fix-only-full-group-by-errors
branch
from
bd5c742 to
7b0141e
Compare
pstaabp
approved these changes
Sep 9, 2025
drgrice1
force-pushed
the
fix-only-full-group-by-errors
branch
2 times, most recently
from
44a7585 to
7e07ac5
Compare
drgrice1
force-pushed
the
fix-only-full-group-by-errors
branch
from
7e07ac5 to
ffab6e8
Compare
If `only_full_group_by` is included in the `sql_mode` mysql settings, then attempting to view problems in the library browser results in an exception with a message like `DBD::MariaDB::db selectall_arrayref failed: 'webwork.pgf.morelt_id' isn't in GROUP BY at /opt/webwork/webwork2/lib/WeBWorK/DB/Database.pm line 137.` This just adds a `MAX` call to the columns of the `OPL_pgfile` table that are selected in the `GROUP BY` call, and eliminates the exception. The resulting data that is returned in the query is the same as before since these columns will all hold the same data for the grouped `filepath` results. This is really just working around poor design in the OPL table structure. This has been noted a few times in the forums recently. See, for instance, the latest posts in https://forums.openwebwork.org/mod/forum/discuss.php?d=8757#p22352. To test this set ``` sql_mode = "ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION" ``` in the `/etc/mysql/conf.d/mysql.cnf` file and execute `sudo systemctl restart msyql`. With the shown value for `sql_mode` and the develop or main branches you will get the exception when you try to view problems in the library browser, but will not with this pull request. Note that the value for `sql_mode` above seems to be the default for MariaDB if `ONLY_FULL_GROUP_BY` is removed. At least that is the case on my system. You can execute `select @@sql_mode` in mysql to see what the settings are for your system. The default for MySQL does include `ONLY_FULL_GROUP_BY` (at least if I am reading things right).
drgrice1
force-pushed
the
fix-only-full-group-by-errors
branch
from
ffab6e8 to
a00d70a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
only_full_group_byis included in thesql_modemysql settings, then attempting to view problems in the library browser results in an exception with a message likeDBD::MariaDB::db selectall_arrayref failed: 'webwork.pgf.morelt_id' isn't in GROUP BY at /opt/webwork/webwork2/lib/WeBWorK/DB/Database.pm line 137.This just adds a
MAXcall to the columns of theOPL_pgfiletable that are selected in theGROUP BYcall, and eliminates the exception. The resulting data that is returned in the query is the same as before since these columns will all hold the same data for the groupedfilepathresults. This is really just working around poor design in the OPL table structure.This has been noted a few times in the forums recently. See, for instance, the latest posts in https://forums.openwebwork.org/mod/forum/discuss.php?d=8757#p22352.
To test this set
in the
/etc/mysql/conf.d/mysql.cnffile and executesudo systemctl restart msyql. With the shown value forsql_modeand the develop or main branches you will get the exception when you try to view problems in the library browser, but will not with this pull request.Note that the value for
sql_modeabove seems to be the default for MariaDB ifONLY_FULL_GROUP_BYis removed. At least that is the case on my system. You can executeselect @@sql_modein mysql to see what the settings are for your system. The default for MySQL does includeONLY_FULL_GROUP_BY(at least if I am reading things right).