Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove presentation decoding #50

Merged
merged 2 commits into from
Mar 4, 2025
Merged

chore: remove presentation decoding #50

merged 2 commits into from
Mar 4, 2025

Conversation

TimoGlastra
Copy link
Contributor

Remove the decoding from this library, this needs to be handled by the user of this library.

I did return expectedNonce, to indicate which nonce should be verified against. I also added a todo related to transaction data hashes (see #49)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Signed-off-by: Timo Glastra <[email protected]>
Copy link

changeset-bot bot commented Mar 3, 2025

⚠️ No Changeset found

Latest commit: f0c1b38

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TimoGlastra TimoGlastra requested a review from auer-martin March 3, 2025 13:23
@TimoGlastra TimoGlastra linked an issue Mar 3, 2025 that may be closed by this pull request

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Signed-off-by: Timo Glastra <[email protected]>
Copy link
Contributor

@auer-martin auer-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


export const zVpTokenDcql = z.record(z.union([z.string(), z.record(z.any())]), {
message:
'dcql vp_token must be an object with keys referencing the dcql credential query id, and values the encoded (string or object) presentation',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any chance to get support for upcoming draft 25?
The main change for DCQL is that there can be multiple presentations for a credential query id, e.g.

{
  "credential_query_id_1": [....]
}

See openid/OpenID4VP@4a6aaa9

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah should be quite simple to support. We'd need to make the needed changes in the DCQL library as well.

Let's wait for 25 to be published, and then we can add support for it

@TimoGlastra TimoGlastra merged commit f79ba78 into main Mar 4, 2025
11 checks passed
@TimoGlastra TimoGlastra deleted the remove-decoding branch March 4, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Presentation parsing improvements
3 participants