Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore response uri validation for signed dc api requests #44

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

TimoGlastra
Copy link
Contributor

I think we can just ignore the redirect/response uri validation when doing DC API requests?

I also opened an issue to be sure: openid/OpenID4VP#437

Signed-off-by: Timo Glastra <[email protected]>
Copy link

changeset-bot bot commented Feb 25, 2025

⚠️ No Changeset found

Latest commit: 1e9620d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TimoGlastra TimoGlastra merged commit fa6ca15 into main Feb 25, 2025
5 checks passed
@TimoGlastra TimoGlastra deleted the fix/signed-dc-reqeusts branch February 25, 2025 20:42
@TimoGlastra
Copy link
Contributor Author

TimoGlastra commented Feb 25, 2025

Merging as it blocks dc integration (feel free to leave comments still)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant