Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transaction data verification method #49

Closed
TimoGlastra opened this issue Mar 3, 2025 · 2 comments · Fixed by #51
Closed

Add transaction data verification method #49

TimoGlastra opened this issue Mar 3, 2025 · 2 comments · Fixed by #51
Labels
OID4VP

Comments

@TimoGlastra
Copy link
Contributor

TimoGlastra commented Mar 3, 2025 •
edited
Loading

You provide to this library an array with:

  • authorization request
  • credential id (pex input descriptor id or dcql credential query id)
  • credential hashes
  • credential hash alg (optional)

The library will validate it against the transaction_data array and ensure the hashes match (using the hash callback).
@TimoGlastra TimoGlastra mentioned this issue Mar 3, 2025
Merged
@auer-martin
Copy link
Contributor

Sounds good to me! 👍🏻

@TimoGlastra
Copy link
Contributor Author

I tried implementing this, but ran into some complications.

For now I'll just hash using all specified hashing algorithms and compare

@TimoGlastra TimoGlastra mentioned this issue Mar 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OID4VP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: verify transaction data openwallet-foundation-labs/oid4vc-ts
2 participants
@TimoGlastra @auer-martin