Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deep link parsing errors for VP Requests #712

Merged
merged 8 commits into from
Apr 8, 2025
Merged

Fix deep link parsing errors for VP Requests #712

merged 8 commits into from
Apr 8, 2025

Conversation

dmitrizagidulin
Copy link
Contributor

@dmitrizagidulin dmitrizagidulin commented Mar 13, 2025 •
edited
Loading

  • Fix deep link parsing errors (for requesting VCs via deep link) (was missing percent encoding)
  • Refactor, Add tests for credentialMatchesVprExampleQuery and filterCredentialRecordsByType functions
  • Add additional console logs for debugging purposes

@alexfigtree
Copy link
Contributor

alexfigtree commented Mar 13, 2025 •
edited by dmitrizagidulin
Loading

Addresses #697, digitalcredentials/web-verifier-plus#166 and digitalcredentials/web-verifier-plus#164

@alexfigtree
Copy link
Contributor

@dmitrizagidulin Linting error is due to following error: 'request' is assigned a value but never used @typescript-eslint/no-unused-vars

@dmitrizagidulin
Refactor, add tests to VC query by type.
5fd9fff 
Signed-off-by: Dmitri Zagidulin <[email protected]>
@dmitrizagidulin
Fix postToExchange params.
97b60b4 
Signed-off-by: Dmitri Zagidulin <[email protected]>
@dmitrizagidulin
Fix sending exchange request.
cbb2138 
Signed-off-by: Dmitri Zagidulin <[email protected]>
@dmitrizagidulin dmitrizagidulin changed the title Catch and log deep link parsing errors. Fix deep link parsing errors for VP Requests Mar 17, 2025
@dmitrizagidulin dmitrizagidulin marked this pull request as ready for review March 17, 2025 15:18
@dmitrizagidulin dmitrizagidulin mentioned this pull request Mar 17, 2025
Merged
@alexfigtree alexfigtree self-requested a review March 19, 2025 19:12
@alexfigtree alexfigtree moved this to Ready for PR Review/re-test in Learner Credential Wallet Mar 19, 2025
alexfigtree
alexfigtree reviewed Mar 31, 2025
View reviewed changes
Copy link
Contributor

@alexfigtree alexfigtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with V+ and working

alexfigtree
alexfigtree approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@alexfigtree alexfigtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with V+ and working

@alexfigtree
Copy link
Contributor

Clicking on NO the credentials request popup results in error:
Screenshot 2025-04-01 at 11 16 58 AM

Screenshot 2025-04-01 at 3 15 10 PM

Opening up this issue for it: Clicking on NO the credentials request popup results in error #721

@alexfigtree alexfigtree mentioned this pull request Apr 2, 2025
Open
@alexfigtree
Copy link
Contributor

Also fixes #721

@alexfigtree alexfigtree force-pushed the fix-deep-link-parsing branch from 8d5415b to 3fe55b3 Compare April 3, 2025 21:36
@alexfigtree
Copy link
Contributor

GO_BACK issue was fixed with last commit, good to merge

@alexfigtree alexfigtree merged commit ecde425 into main Apr 8, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Ready for PR Review/re-test to Done in Learner Credential Wallet Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfigtree alexfigtree alexfigtree approved these changes

Assignees

@dmitrizagidulin dmitrizagidulin

Labels
None yet
Projects
Learner Credential Wallet
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitrizagidulin @alexfigtree