Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplatform camera #929

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

koukarine
Copy link
Contributor

  • Implement iOS camera Composable with KMP

  • Preliminary frame data processing code placeholders.

  • Tests pass

@koukarine koukarine requested a review from davidz25 March 20, 2025 22:31
@koukarine koukarine force-pushed the multiplatform-camera branch 2 times, most recently from 8716eb4 to a9639e3 Compare March 20, 2025 23:09
Copy link
Contributor

@davidz25 davidz25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one comment about leaving FrameProcessor out of this commit + left a comment on the team chat about the commit message. Apart from that LGTM but I'll let Kevin approve it.

@koukarine koukarine force-pushed the multiplatform-camera branch from a9639e3 to 44da9b9 Compare March 21, 2025 23:58
- Camera Composable with preview implemented for Android and iOS using KMP.
- New "Camera" item with the corresponding "Camera" screen for upcoming camera operations selection added to samples/testapp. It provides two options showing the AlertDialog with the camera preview for selected cameras as an example of using the new KMP Composable.

Test: All Unit tests are passing.
Test: Manually tested via samples/testapp on Android and iPhone.

Signed-off-by: koukarine <[email protected]>
@koukarine koukarine force-pushed the multiplatform-camera branch from 44da9b9 to 4eb24ca Compare March 21, 2025 23:58
@koukarine koukarine requested a review from davidz25 March 22, 2025 00:03
@koukarine koukarine requested a review from kdeus March 22, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants