Compilation with src and bin tokenizers, genai and oponvino. #3657
Conversation
…-173265_genai_build
| #include "absl/status/status.h" | ||
| #pragma warning(pop) | ||
| #include "../io_processing/output_parser.hpp" | ||
| #include "../generation_config_header.hpp" |
There was a problem hiding this comment.
| #include "../generation_config_header.hpp" | |
| #include "src/llm/generation_config_header.hpp" |
| #include <utility> | ||
| #include <openvino/genai/generation_config.hpp> | ||
|
|
||
| #include "../../generation_config_header.hpp" |
There was a problem hiding this comment.
| #include "../../generation_config_header.hpp" | |
| #include "src/llm/generation_config_header.hpp" |
| #include <openvino/genai/generation_config.hpp> | ||
|
|
||
| #include "generation_config_builder.hpp" | ||
| #include "../../generation_config_header.hpp" |
There was a problem hiding this comment.
| #include "../../generation_config_header.hpp" | |
| #include "src/llm/generation_config_header.hpp" |
| #include <openvino/genai/generation_config.hpp> | ||
|
|
||
| #include "generation_config_builder.hpp" | ||
| #include "../../generation_config_header.hpp" |
There was a problem hiding this comment.
And
| #include "../../generation_config_header.hpp" | |
| #include "src/llm/generation_config_header.hpp" |
And to all other includes use non-relative path.
| WORKDIR /openvino_tokenizers/ | ||
| # Install the openvino_tokenizers python bindings and copy to OpenVINO location | ||
| RUN if ! [[ $debug_bazel_flags == *"_py_off"* ]]; then \ | ||
| RUN if [ "$ov_use_binary" == "0" ]; then true ; else exit 0 ; fi ; \ |
There was a problem hiding this comment.
Idea worth considering:
We could have "build_ov/genai.sh/bat" that will use variables defined in the container (stored in env.txt?).
Then in case of upgrade in OV we wouldn;t have to rebuild build container from scratch - just relaunch this script
spelling-whitelist.txt
Outdated
| @@ -1,3 +1,5 @@ | |||
| Dockerfile.redhat:228: thirdparty ==> third party, third-party | |||
| Dockerfile.ubuntu:206: thirdparty ==> third party, third-party | |||
There was a problem hiding this comment.
There's nothing like that in L206 in Ubuntu dockerfile
| load("@ovms//third_party/aws-sdk-cpp:aws-sdk-cpp.bzl", "aws_sdk_cpp") | ||
| aws_sdk_cpp() | ||
|
|
||
| ### OpenVINO GenAI |
There was a problem hiding this comment.
Since we remove this we need synchronize this with Mediapipe repository update
| class EmbeddingsExtensionTest : public ::testing::Test { | ||
| protected: | ||
| static std::unique_ptr<std::thread> t; | ||
| static std::unique_ptr<std::thread> t1; |
There was a problem hiding this comment.
Couldn't we just wait in single thread for all servables?
| --build-arg ov_genai_org=$(OV_GENAI_ORG)\ | ||
| --build-arg ov_tokenizers_org=$(OV_TOKENIZERS_ORG)\ | ||
| --build-arg ov_contrib_org=$(OV_CONTRIB_ORG)\ | ||
| --build-arg ov_contrib_branch=$(OV_CONTRIB_BRANCH)\ |
There was a problem hiding this comment.
contrib is not used anymore
🛠 Summary
JIRA CVS-173265
🧪 Checklist
``