Skip to content

Conversation

dtrawins
Copy link
Collaborator

@dtrawins dtrawins commented Sep 6, 2025

🛠 Summary

JIRA/Issue if applicable.
Describe the changes.

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

:: limitations under the License.
::
echo off
@echo on
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to have all logs in CI ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it shows the commands executed. Otherwise there is no information about the fail reason.

set "TOKENIZER_SOURCE_BRANCH=master"
)

IF /I NOT EXIST openvino (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets keep the build outside of model_server git repository.
instead of openvino change path to c:!output_user_root!\openvino_src and use it in consecutive commands.

IF /I NOT EXIST openvino_tokenizers (
git clone https://github.com/%TOKENIZER_SOURCE_ORG%/openvino_tokenizers.git
)
cd openvino_tokenizers
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets keep the build outside of model_server git repository.
instead of openvino_tokenizerschange path to c:!output_user_root!\openvino_tokenizers_src and use it in consecutive commands.

Copy link
Collaborator

@rasapala rasapala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change build paths. Is it good idea to take the parameter from env variables. Maybe better to pass it as a 3rd argument to the scripts ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants